Skip to content

Turn battle and narrative check rule packs (RPG R6) - #75

Merged
luoxin9510 merged 1 commit into
mainfrom
rpg-r6-packs
Nov 10, 2026
Merged

luoxin9510 merged 1 commit into
mainfrom
rpg-r6-packs

Conversation

@luoxin9510

Copy link
Copy Markdown
Owner

Two new first-party packs under packs/. Both show up in "New game".

  • turn-battle: a 3 on 3 JRPG-style battle. Everyone acts once a round, fastest first; heroes have attacks, arts (bash, fireball, mend), guard and potions; foes can poison and be stunned. Damage is 2d6. It uses only R1–R4 pieces: no engine changes. A strategy bot wins 88% of 500 battles and random play wins 17%.
  • narrative-check: dorm-302's rules plus clamp(). dorm-302 switched to a vendored copy (luoxin9510/dorm-302 branch narrative-check-pack). Its check-ink --all --novelty --random 300 output is byte-for-byte identical before and after the switch, in both zh and en.
  • Tests: each template is current and plays to an ending; a 3 on 3 round follows speed order. All 600 tests pass.
  • Not in this PR: vault tutorials 10.6/10.7 and the Obsidian check (that needs the plugin deployed).

🤖 Generated with Claude Code

https://claude.ai/code/session_015vdVgYTb9jm7MRdePSgs8B

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015vdVgYTb9jm7MRdePSgs8B
@claude

claude Bot commented Nov 10, 2026

Copy link
Copy Markdown

Review of the two new packs (turn-battle, narrative-check). I read packs/turn-battle/rules.ink and system.md closely. I did not run the test suite (the sandbox blocked it), so I can't confirm tests/packs.test.ts and tests/system.test.ts pass. I did not read the narrative-check pack, the other templates, or the test diffs.

No blocking bugs found in turn-battle. The pack adds no src/ code, so the Node/Electron, T(), innerHTML and minAppVersion checks don't apply.

One minor point: rules.ink uses stat(x, "art") == 0 to mean "this is a foe" (battle and hurt). A hero a game adds with art: 0 would be played as a foe, and hurt would treat it as a foe and remove it instead of laying it down at 0 HP. This is fine for the shipped party, but worth a comment in the header or a separate foe flag.

I would merge as is, provided CI is green (it runs the pack tests).

@luoxin9510
luoxin9510 merged commit 0e3903b into main Nov 10, 2026
2 checks passed
@luoxin9510
luoxin9510 deleted the rpg-r6-packs branch November 10, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant